Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally check values in DocValuesCodecDuelTests #110056

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conditionally check values in DocValuesCodecDuelTests #110056

merged 1 commit into from
Jun 21, 2024

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jun 21, 2024 •
edited
Loading

We are currently reading the doc-values unconditionally, without checking whether advance has reached the end or if advanceExact returns false.

Relates #108928

@dnhatn dnhatn added :StorageEngine/TSDB You know, for Metrics >test Issues or PRs that are addressing/adding tests v8.14.1 auto-backport-and-merge Automatically create backport pull requests and merge when ready labels Jun 21, 2024
@dnhatn dnhatn requested review from martijnvg and lkts June 21, 2024 17:09
@dnhatn dnhatn marked this pull request as ready for review June 21, 2024 17:10
@dnhatn dnhatn mentioned this pull request Jun 21, 2024
Closed
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@dnhatn
Copy link
Member Author

dnhatn commented Jun 21, 2024

Thanks @lkts.

@dnhatn dnhatn merged commit 7e0be72 into elastic:main Jun 21, 2024
15 checks passed
@dnhatn dnhatn deleted the fix-dvtests branch June 21, 2024 19:06
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.14 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 110056

martijnvg
martijnvg reviewed Jun 24, 2024
View reviewed changes
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 - I was looking into this test failure just before logging off for the weekend and came to the same conclusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martijnvg martijnvg martijnvg left review comments

@lkts lkts lkts approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending :StorageEngine/TSDB You know, for Metrics Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.14.1 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dnhatn @elasticsearchmachine @martijnvg @lkts