Handle malformed date when objects are supplied #110049
Conversation
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @salvatore-campagna, I've created a changelog YAML for you. |
server/src/main/java/org/elasticsearch/index/mapper/DateFieldMapper.java
Show resolved
Hide resolved
| refresh: true | ||
| index: test | ||
| id: "2" | ||
| body: { "date_ignored": [ 1, 2, 3 ], "date_not_ignored": "2024-02-03T10:12:43.123Z", date_nanos_ignored: [ 10, 20, 30 ], "date_nanos_not_ignored": "2024-02-03T10:12:43.123456789Z" } |
There was a problem hiding this comment.
@mvg see this
| refresh: true | ||
| index: test | ||
| id: "3" | ||
| body: { "date_ignored": [ { "key": "a", "value": 10 }, { "key": "c", "value": 100 } ], "date_not_ignored": "2024-02-03T10:12:43.123Z", date_nanos_ignored: [ { "key": "b", "value": 20 }, { "key": "d", "value": 40 } ], "date_nanos_not_ignored": "2024-02-03T10:12:43.123456789Z" } |
There was a problem hiding this comment.
@mvg and this other one
This reverts commit 579675b.
| } | ||
| return; | ||
| } else { | ||
| throw new IllegalArgumentException("Unable to parse object as a " + mappedFieldType.name() + " field"); |
There was a problem hiding this comment.
Paranoid check - isn't this an API change? Previously we would have returned an error directly from parser which is not only a different text but a different type of exception.
There was a problem hiding this comment.
I will double check this...probably I will add also full-bwc label.
There was a problem hiding this comment.
AT least I hope this is tested...but probably it is not...
There was a problem hiding this comment.
Yea i don't know if we explicitly test such things.
| index: | ||
| refresh: true | ||
| index: test | ||
| id: "1" |
There was a problem hiding this comment.
Is it intentional that we use the same id as previous successful request?
There was a problem hiding this comment.
No this is a mistake.
| - match: { hits.hits.0._source.date_nanos_ignored.value: 20 } | ||
| - match: { hits.hits.0._source.date_nanos_not_ignored: "2024-02-03T10:12:43.123456789Z" } | ||
|
|
||
| # NOTE: this is interesting...numeric values translate to millis since epoch |
There was a problem hiding this comment.
Default format indeed accepts epoch_millis so these are not malformed.
There was a problem hiding this comment.
I need to test a couple of more cases...arrays with valid values and arrays with mixed valid and invalid values.
When an
objectis supplied as a value for a field whose type isdateordate_nanoswe needto trigger handling of the field value using our ignore malformed handling strategy.
Resolves #109539