Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESQL: make named params objects truly per request #110046

Merged
merged 8 commits into from
Jun 22, 2024

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Jun 21, 2024

Fixes #110028

@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jun 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@elasticsearchmachine
Copy link
Collaborator

Hi @astefan, I've created a changelog YAML for you.

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -182,6 +185,20 @@ public void testInvalidParams() throws IOException {
);
}

// Test for https://github.com/elastic/elasticsearch/issues/110028
public void testNamedParamsMutation() {
Copy link
Member

@fang-xing-esql fang-xing-esql Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, thank for fixing it!!

@astefan astefan merged commit 7bed391 into elastic:main Jun 22, 2024
15 checks passed
@astefan astefan deleted the 110028_fix branch June 22, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >bug Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
4 participants