Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IndexRecoveryIT#testSourceThrottling #110044

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

fcofdez
Copy link
Contributor

@fcofdez fcofdez commented Jun 21, 2024

Ensure that the target node has a high enough recovery max bytes per second to avoid any accidental throttling.

Closes #110026

Ensure that the target node has a high enough recovery max bytes
per second to avoid any accidental throttling.

Closes elastic#110026
@fcofdez fcofdez added >test Issues or PRs that are addressing/adding tests :Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Meta label for distributed team v8.15.0 labels Jun 21, 2024
@fcofdez fcofdez requested a review from arteam June 21, 2024 13:18
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@fcofdez
Copy link
Contributor Author

fcofdez commented Jun 21, 2024

I couldn't reproduce the test failure but in the two failures that I looked into the target node had a "low" recovery max bytes per second setting (

RecoverySettings.INDICES_RECOVERY_MAX_BYTES_PER_SEC_SETTING.getKey(),
) so my suspicion is that the source node gets the setting update first and sends enough data to cause a small throttle in the target node before it updates its recovery max bytes per second.

Copy link
Contributor

@arteam arteam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM! The idea sounds plausible.

@fcofdez fcofdez merged commit b8b7101 into elastic:main Jun 21, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Recovery Anything around constructing a new shard, either from a local or a remote source. Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] IndexRecoveryIT testSourceThrottling failing
3 participants