Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable DEBUG logging for testQueuedOperationsOnMasterDisconnect #110037

Conversation

pxsalehi
Copy link
Member

I cannot reproduce this and I cannot find out why it fails.

Relates #108237

@pxsalehi pxsalehi added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs labels Jun 21, 2024
@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team v8.15.0 labels Jun 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@pxsalehi pxsalehi requested a review from ywangd June 21, 2024 12:19
Copy link
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -674,9 +675,17 @@ public void testQueuedOperationsOnMasterRestart() throws Exception {
awaitNoMoreRunningOperations();
}

@TestLogging(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Based its javadoc, we should use @TestIssueLogging instead

@pxsalehi pxsalehi added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 21, 2024
@elasticsearchmachine elasticsearchmachine merged commit 5e9a3dc into elastic:main Jun 21, 2024
15 checks passed
@pxsalehi pxsalehi deleted the ps240621-logging-testQueuedOperationsOnMasterDisconnect branch June 21, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants