[ESQL] repalce string switch with enum switch #110036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
bpintea
approved these changes
Jun 21, 2024
not-napoleon
added
the
auto-merge
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jun 25, 2024
Similar to #110036, this creates the opportunity for the compiler to flag this as a place which needs to be changed when we add a data type. It's also fewer lines of code, and makes it explicit which types are not supported. Ideally, this would also become a property on DataType, but that can't happen until we pull it out of core.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that data types are an enum, we can just switch on the objects themselves, rather than needing to use the string versions. This way, we can get a compile time error if we add a type and forget to account for it here.
Ideally, we'd move this to just be a field on the enum itself, but because
DataTypeis still in core, we don't have the correct visibility. If we move it out of core, it might be worth revisiting this.