Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPEs in CO2Calculator.getKiloWattsPerCore() #110024

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Fix NPEs in CO2Calculator.getKiloWattsPerCore() #110024

merged 1 commit into from
Jun 24, 2024

Conversation

rockdaboot
Copy link
Contributor

Fixes #109953

  • Set proper defaults for HostMetadata instances
  • Add tests that trigger the bug

@rockdaboot rockdaboot added >bug :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.14.2 labels Jun 21, 2024
@rockdaboot rockdaboot self-assigned this Jun 21, 2024
@elasticsearchmachine elasticsearchmachine added Team:obs-knowledge Meta label for Observability Knowledge team v8.15.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 21, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/obs-knowledge-team (Team:obs-knowledge)

@rockdaboot rockdaboot mentioned this pull request Jun 21, 2024
Closed
7 tasks
@rockdaboot rockdaboot added >test Issues or PRs that are addressing/adding tests and removed external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jun 21, 2024
crespocarlos
crespocarlos approved these changes Jun 24, 2024
View reviewed changes
Copy link
Contributor

@crespocarlos crespocarlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@rockdaboot rockdaboot merged commit d9f18e8 into elastic:main Jun 24, 2024
15 checks passed
rockdaboot added a commit to rockdaboot/elasticsearch that referenced this pull request Jun 30, 2024
@rockdaboot
Fix NPEs in CO2Calculator.getKiloWattsPerCore() (elastic#110024)
9282074
@rockdaboot rockdaboot mentioned this pull request Jun 30, 2024
Merged
elasticsearchmachine pushed a commit that referenced this pull request Jul 1, 2024
@rockdaboot @elasticmachine
Fix NPEs in CO2Calculator.getKiloWattsPerCore() (#110024) (#110308)
2afe7ca 
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crespocarlos crespocarlos crespocarlos approved these changes

Assignees

@rockdaboot rockdaboot

Labels
>bug Team:obs-knowledge Meta label for Observability Knowledge team >test Issues or PRs that are addressing/adding tests :UniversalProfiling/Application Elastic Universal Profiling REST APIs and infrastructure v8.14.2 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullPointerException in the Profiling plugin (xpack.profiling.action.CO2Calculator.getKiloWattsPerCore)
3 participants
@rockdaboot @elasticsearchmachine @crespocarlos