Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt in keyword field into fallback synthetic source when doc values are disabled #110016

Merged
merged 6 commits into from
Jun 25, 2024

Conversation

lkts
Copy link
Contributor

@lkts lkts commented Jun 20, 2024

Contributes to #109546. Note that this PR only handles keyword fields.

@lkts lkts added >enhancement :StorageEngine/Mapping The storage related side of mappings labels Jun 20, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @lkts, I've created a changelog YAML for you.

@lkts lkts marked this pull request as ready for review June 24, 2024 22:43
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts lkts requested a review from martijnvg June 24, 2024 22:44
Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkts lkts merged commit 653b99a into elastic:main Jun 25, 2024
15 checks passed
@lkts lkts deleted the fix/109546 branch June 25, 2024 16:35
@lkts lkts changed the title Opt in keyword field into fallback synthetic source if needed Opt in keyword field into fallback synthetic source when doc values are disabled Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants