Permit extended plugins to share code #110011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
prdoyle
added
>non-issue
:Core/Infra/Plugins
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
elasticsearchmachine
removed
the
needs:triage
rjernst
approved these changes
Jun 20, 2024
|
Hmm maybe we should leave the check and log an |
If there is a real problem the real jar hell check right below will catch it. I think we can safely remove this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the situation where a plugin A extends plugins B and C, and also B extends C. There's no actual trouble here, because there's only going to be one of each class in use at runtime, but we're currently forbidding it.