Remove time_interval from time series source operator #109982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
force-pushed
the
remove-time-bucket
branch
2 times, most recently
from
e06dd66
to
7ef4eed
Compare
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
force-pushed
the
remove-time-bucket
branch
from
7ef4eed
to
aa93b96
Compare
kkrik-es
approved these changes
Jun 21, 2024
|
Thanks @kkrik-es. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the time_bucket from the time-series source operator. This should simplify the planner. Running a separate date trunc eval specified by bucket should yield the same output and performance.
Spin-off from #109979