Remove test only MapperMergeContext#root method #109966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MapperMergeContext exposes a package private static root method that is only used in tests. That makes the production code slightly harder to follow because there are two possible code-paths. This commit simplifies that by moving the logic around providing a mapping reason to the caller tests, and removes the additional root method that is not needed in prod code.
javanna
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jun 21, 2024
MapperMergeContext exposes a package private static root method that is only used in tests. That makes the production code slightly harder to follow because there are two possible code-paths. This commit simplifies that by moving the logic around providing a mapping reason to the caller tests, and removes the additional root method that is not needed in prod code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapperMergeContext exposes a package private static root method that is only used in tests. That makes the production code slightly harder to follow because there are two possible code-paths. This commit simplifies that by moving the logic around providing a mapping reason to the caller tests, and removes the additional root method that is not needed in prod code.