Propagate mapper builder context flags across nested mapper builder context creation #109963
+148
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @javanna, I've created a changelog YAML for you. |
martijnvg
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Maybe add a yaml test with a mapping that uses a nested field type, which has a sub field of type date or long with ignore_malformed enabled. Also enable index.mode=logs. Index a document with that structure and with a malformed value. Then assert that the malformed value can be retrieved from _source. I expect this to fail without this fix.
…ontext creation MapperBuilderContext includes information about whether synthetic source is configured, we are in a data streams and there are dimensions. This info is currently not propagated across the constructor of NestedMapperBuilderContext, which means that the builder context for the nested type receives hardcoded (false) info. This commit fixes that.
javanna
force-pushed
the
fix/propagate_nested_mapper_builder_context_flags
branch
from
280c0a6
to
58382df
Compare
martijnvg
approved these changes
Jun 21, 2024
|
@elasticmachine run elasticsearch-ci/part-1 |
javanna
added
v8.14.2
auto-backport
💔 Backport failed
You can use sqren/backport to manually backport by running |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jun 24, 2024
…ontext creation (elastic#109963) MapperBuilderContext includes information about whether synthetic source is configured, we are in a data streams and there are dimensions. This info is currently not propagated across the constructor of NestedMapperBuilderContext, which means that the builder context for the nested type receives hardcoded (false) info. This commit fixes that. One symptom of this, due to not propagating the info about whether synthetic source is configured, is that numeric fields that have ignore_malformed set to true, mapped under a nested type, will cause shard failures whenever a document with ignored values is retrieved in the fetch phase
javanna
removed
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MapperBuilderContext includes information about whether synthetic source is configured, we are in a data streams and there are dimensions. This info is currently not propagated across the constructor of NestedMapperBuilderContext, which means that the builder context for the nested type receives hardcoded (false) info. This commit fixes that.
One symptom of this, due to not propagating the info about whether synthetic source is configured, is that numeric fields that have
ignore_malformedset totrue, mapped under anestedtype, will cause shard failures whenever a document with ignored values is retrieved in the fetch phase: