Add a project-id to ProjectMetadata #109955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This replaces `Metadata.Custom` with two new interfaces - `Metdata.ClusterCustom` - `Metdata.ProjectCustom` Every implementation of `Custom` has been converted to one of these two interfaces based on whether it is topological (Cluster) based (such as Autoscaling and DesiredNodes) or data (Project) based (such as DataStreams and Templates)
Otherwise the node tool cannot tell what to parse as a cluster custom and what to treat as a project custom
ClusterState has two accessor methods for the same field. This makes mocking painful. Use "metadata()" consistently in these tests
This adds backward compatibility code to handle cluster `Metadata` (and `MetadataDiff`) to versions that have a single `Custom` interface (before the split to `ClusterCustom` and `ProjectCustom`)
This commit adds a new `ProjectMetadata` class and migrates fields from `Metadata` into the new class. Each `Metadata` instance has exactly one `ProjectMetadata` field. The API to `Metadata` is essentially unchanged with existing methods delegating to methods on the new class. However, serialization (Transport and XContent) has changed to reflect the new class structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No plans to merge, just here for CI
Builds on #109460 and #109659