Automatically adjust ignore_malformed only for the @timestamp #109948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @javanna, I've created a changelog YAML for you. |
original-brownbear
approved these changes
Jun 20, 2024
| @@ -359,7 +359,7 @@ public DateFieldMapper build(MapperBuilderContext context) { | |||
| ); | |||
|
|
|||
| Long nullTimestamp = parseNullValue(ft); | |||
| if (name().equals(DataStreamTimestampFieldMapper.DEFAULT_PATH) | |||
There was a problem hiding this comment.
I like the TODO on name() :D
There was a problem hiding this comment.
Yes, I think that this is a good reason to finally remove the TODO, I think I added the TODO 5ish years ago....
We introduced automatic disabling ignore_malformed for the @timestamp field with elastic#99346, but the change was applied to any field with name @timestamp under any path, while it should have been applied only to the top-level @timestamp field. Relates to elastic#107760
javanna
force-pushed
the
fix/ignore_malformed_timestamp_object
branch
from
346167c
to
0c21a27
Compare
💔 Backport failed
You can use sqren/backport to manually backport by running |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jul 2, 2024
…c#109948) We introduced automatic disabling ignore_malformed for the @timestamp field with elastic#99346, but the change was applied to any field with name @timestamp under any path, while it should have been applied only to the top-level @timestamp field. Relates to elastic#107760
javanna
added a commit
that referenced
this pull request
Jul 2, 2024
We introduced automatic disabling ignore_malformed for the @timestamp field with #99346, but the change was applied to any field with name @timestamp under any path, while it should have been applied only to the top-level @timestamp field. Relates to #107760
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced automatic disabling ignore_malformed for the @timestamp field with #99346, but the change was applied to any field with name @timestamp under any path, while it should have been applied only to the top-level @timestamp field.
Relates to #107760