Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use to VectorScorer for exact vector scoring #109945

Conversation

benwtrent
Copy link
Member

Lucene 9.11 introduced a new VectorScorer interface. We should utilize this interface when scoring exact vectors.

related to: #109293

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

Copy link
Contributor

@tteofili tteofili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with a minor comment

Comment on lines 139 to 140
public String toString(String field) {
return "ExactKnnQuery.Floats";
Copy link
Contributor

@tteofili tteofili Jun 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't it be "ExactKnnQuery.Bytes"?

Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent changed the title Feature/move to vector scorer for exact vector Use to VectorScorer for exact vector scoring Jun 20, 2024
@benwtrent benwtrent added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 20, 2024
@benwtrent
Copy link
Member Author

@elasticmachine update branch

@elasticsearchmachine elasticsearchmachine merged commit 3faf4ce into elastic:main Jun 20, 2024
15 checks passed
@benwtrent benwtrent deleted the feature/move-to-vector-scorer-for-exact-vector branch June 20, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >refactoring :Search Relevance/Vectors Vector search Team:Search Meta label for search team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants