Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TasksIT#testTasksCancellation #109929

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Fix TasksIT#testTasksCancellation #109929

merged 2 commits into from
Jun 19, 2024

Conversation

DaveCTurner
Copy link
Contributor

The tasks are removed from the task manager after sending the
response, so we cannot reliably assert they're done. With this commit we
wait for them to complete properly first.

Closes #109686

@DaveCTurner
Fix TasksIT#testTasksCancellation
4bf8068 
The tasks are removed from the task manager _after_ sending the
response, so we cannot reliably assert they're done. With this commit we
wait for them to complete properly first.

Closes elastic#109686
@DaveCTurner DaveCTurner added >test Issues or PRs that are addressing/adding tests :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. v8.15.0 v8.14.2 labels Jun 19, 2024
@DaveCTurner DaveCTurner added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label Jun 19, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Jun 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@DaveCTurner DaveCTurner added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 19, 2024
@elasticsearchmachine elasticsearchmachine merged commit 56a19f9 into elastic:main Jun 19, 2024
15 checks passed
@DaveCTurner DaveCTurner deleted the 2024/06/19/fix-testTasksCancellation branch June 19, 2024 16:04
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request Jun 19, 2024
@DaveCTurner
Fix TasksIT#testTasksCancellation (elastic#109929)
6a7c918 
The tasks are removed from the task manager _after_ sending the
response, so we cannot reliably assert they're done. With this commit we
wait for them to complete properly first.

Closes elastic#109686
@DaveCTurner DaveCTurner mentioned this pull request Jun 19, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.14

elasticsearchmachine pushed a commit that referenced this pull request Jun 19, 2024
@DaveCTurner
[8.14] Fix TasksIT#testTasksCancellation (#109929) (#109941)
342a451 
* Fix `TasksIT#testTasksCancellation` (#109929)

The tasks are removed from the task manager _after_ sending the
response, so we cannot reliably assert they're done. With this commit we
wait for them to complete properly first.

Closes #109686

* Introduce safeGet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idegtiarenko idegtiarenko idegtiarenko approved these changes

@pxsalehi pxsalehi pxsalehi approved these changes

@ywangd ywangd Awaiting requested review from ywangd

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/Task Management Issues for anything around the Tasks API - both persistent and node level. Team:Distributed Meta label for distributed team >test Issues or PRs that are addressing/adding tests v8.14.2 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] TasksIT testTasksCancellation failing
4 participants
@DaveCTurner @elasticsearchmachine @idegtiarenko @pxsalehi