[Inference API] Make AzureOpenAiSecretSettingsTests BWC ready #109928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/ml-core (Team:ML) |
| @@ -143,6 +144,11 @@ protected AzureOpenAiSecretSettings mutateInstance(AzureOpenAiSecretSettings ins | |||
| return randomValueOtherThan(instance, AzureOpenAiSecretSettingsTests::createRandom); | |||
| } | |||
|
|
|||
| @Override | |||
| protected AzureOpenAiSecretSettings mutateInstanceForVersion(AzureOpenAiSecretSettings instance, TransportVersion version) { | |||
| return instance; | |||
There was a problem hiding this comment.
is the idea here that we only have one version, so there is no mutation to do?
There was a problem hiding this comment.
Yes exactly, it kinda acts as a reminder to implement mutation tests, if something on the transport level changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should guard against potential BWC issues in the future by explicitly implementing
AbstractBWCWireSerializationTestCasebeforehand