Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small improvements around routing BulkRequest #109911

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Some small improvements around routing BulkRequest #109911

merged 2 commits into from
Jul 1, 2024

Conversation

original-brownbear
Copy link
Member

We don't need to do the expensive lookup of the index abstraction, we already have it. Also, we can skip the empty string check mostly.

@original-brownbear
Some small improvements around routing BulkRequest
fd61877 
We don't need to do the expensive lookup of the index abstraction, we
already have it. Also, we can skip the empty string check mostly.
@original-brownbear original-brownbear added the :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. label Jun 19, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Jun 19, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

kingherc
kingherc approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@original-brownbear original-brownbear added >non-issue auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) labels Jul 1, 2024
@original-brownbear
Copy link
Member Author

Thanks Iraklis!

@elasticsearchmachine elasticsearchmachine merged commit 9935212 into elastic:main Jul 1, 2024
15 checks passed
@original-brownbear original-brownbear deleted the more-id-cleanup branch July 1, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kingherc kingherc kingherc approved these changes

Assignees
No one assigned
Labels
auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Distributed/CRUD A catch all label for issues around indexing, updating and getting a doc by id. Not search. >non-issue Team:Distributed Meta label for distributed team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@original-brownbear @elasticsearchmachine @kingherc