Log more data for PrevalidateShardPathIT#testCheckShards #109887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`PrevalidateShardPathIT#testCheckShards` still keeps failing on CI, so we need more logging. * Add logging for MasterService to verify that a cluster service update is triggered * Log explanation for stuck shards regardless whether they are located on node_2 in the cluster state See #104807
arteam
added
>test
|
Pinging @elastic/es-distributed (Team:Distributed) |
pxsalehi
approved these changes
Jun 19, 2024
arteam
added
the
auto-merge
|
@elasticmachine update branch |
|
@elasticmachine update branch |
| @@ -39,6 +40,10 @@ | |||
| @ESIntegTestCase.ClusterScope(scope = ESIntegTestCase.Scope.TEST, numDataNodes = 0) | |||
| public class PrevalidateShardPathIT extends ESIntegTestCase { | |||
|
|
|||
| @TestLogging( | |||
| value = "org.elasticsearch.cluster.service.MasterService:DEBUG", | |||
| reason = "https://github.com/elastic/elasticsearch-serverless/pull/2068" | |||
There was a problem hiding this comment.
Should it link #104807 instead?
There was a problem hiding this comment.
Thank you for catching this!
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PrevalidateShardPathIT#testCheckShardsstill keeps failing on CI, so we need more logging.MasterServiceevents to verify that a cluster service update is triggered.See #104807