[Transform] Always pick the user maxPageSize value #109876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxPageSize's update functionality has been reprioritized. If a user calls the update API to change the max page size, that update will lock out other threads from changing the max page size. Once the lock is released, the other threads will check again if they can reset the max page size and otherwise keep the value that the user just updated with. Fix elastic#109844
|
Hi @prwhelan, I've created a changelog YAML for you. |
|
@elasticmachine update branch |
|
Pinging @elastic/ml-core (Team:ML) |
Well I wrote one, I'm not sure if it's a good one, but I'll update this PR and we can always revert it if we don't like it. I tend to prefer when expectations are represented in tests, so I'm inclined to include it, but it requires knowing how the indexer is implemented so it may be obnoxious to maintain so I'm okay with omitting it (which was my initial thought) |
jonathan-buttner
approved these changes
Jun 21, 2024
|
@elasticmachine update branch |
|
The related test is failing on 8.14, should this fix be backported? |
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Jul 29, 2024
maxPageSize's update functionality has been reprioritized. If a user calls the update API to change the max page size, that update will lock out other threads from changing the max page size. Once the lock is released, the other threads will check again if they can reset the max page size and otherwise keep the value that the user just updated with. Relate elastic#109844 Fix elastic#109876
prwhelan
added a commit
that referenced
this pull request
Jul 29, 2024
maxPageSize's update functionality has been reprioritized. If a user calls the update API to change the max page size, that update will lock out other threads from changing the max page size. Once the lock is released, the other threads will check again if they can reset the max page size and otherwise keep the value that the user just updated with. Relate #109844 Fix #109876
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxPageSize's update functionality has been reprioritized. If a user calls the update API to change the max page size, that update will lock out other threads from changing the max page size. Once the lock is released, the other threads will check again if they can reset the max page size and otherwise keep the value that the user just updated with.
Fix #109844