Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES|QL enable FloatBlock serialization #109858

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

ChrisHegarty
Copy link
Contributor

This commit enables ES|QL FloatBlock serialization.

These blocks are currently not sent over the transport, but they could be. How can this be handled at the transport level? Add a new transport version and condition the block registration based on it? Or something more involved?

@ChrisHegarty ChrisHegarty added >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) :Analytics/ES|QL AKA ESQL v8.15.0 labels Jun 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@ChrisHegarty
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ChrisHegarty ChrisHegarty merged commit d5488ad into elastic:main Jun 19, 2024
15 checks passed
@ChrisHegarty ChrisHegarty deleted the esql_float_ser branch June 19, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants