Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Inference API] Use randomOtherValueThan to avoid potential flaky ModelSecretsTests #109857

Merged
merged 4 commits into from
Jun 19, 2024
Merged

[Inference API] Use randomOtherValueThan to avoid potential flaky ModelSecretsTests #109857

merged 4 commits into from
Jun 19, 2024

Conversation

timgrein
Copy link
Contributor

Same reasoning as in #108605. There's a small chance that two calls to createRandomInstance return the same result. Guarding against this case with randomValueOtherThan.

@timgrein timgrein added >non-issue :ml Machine learning Team:ML Meta label for the ML team v8.15.0 labels Jun 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@timgrein timgrein changed the title [Inference API] Use randomOtherValueThan to avoid potential flaky test [Inference API] Use randomOtherValueThan to avoid potential flaky ModelSecretsTests Jun 18, 2024
@timgrein timgrein mentioned this pull request Jun 18, 2024
Merged
@timgrein
Copy link
Contributor Author

@elasticmachine update branch

davidkyle
davidkyle approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@timgrein
Copy link
Contributor Author

@elasticmachine update branch

@timgrein
Copy link
Contributor Author

@elasticmachine update branch

@timgrein timgrein merged commit 3301cef into elastic:main Jun 19, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkyle davidkyle davidkyle approved these changes

Assignees
No one assigned
Labels
:ml Machine learning >non-issue Team:ML Meta label for the ML team v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timgrein @elasticsearchmachine @davidkyle @elasticmachine