Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES|QL: refactor MV tests with shapes #109837

Merged

Conversation

luigidellaquila
Copy link
Contributor

Small refactoring of MV_SLICE and MV_APPEND tests regarding random shape generation.
Moving the logic to limit the size of random shapes to a helper class.

@luigidellaquila luigidellaquila added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL labels Jun 18, 2024
@elasticsearchmachine elasticsearchmachine added v8.15.0 Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) labels Jun 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

@luigidellaquila
Copy link
Contributor Author

@elasticmachine update branch

Copy link
Contributor

@craigtaverner craigtaverner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigidellaquila luigidellaquila added the auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jun 21, 2024
@elasticsearchmachine elasticsearchmachine merged commit 29172b1 into elastic:main Jun 21, 2024
15 checks passed
@luigidellaquila luigidellaquila deleted the esql/shape_tests_refactoring branch June 21, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL auto-merge Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants