[Connector API] Allow Connector status transition to the same status for CONNECTED, CONFIGURED, ERROR #109671
Conversation
jedrazb
added
>non-issue
:SearchOrg/Extract&Transform
jedrazb
requested review from
seanstory,
artem-shelkovnikov and
navarone-feekery
elasticsearchmachine
added
the
Team:SearchOrg
|
Pinging @elastic/ent-search-eng (Team:SearchOrg) |
|
@elasticmachine merge upstream |
There was a problem hiding this comment.
While it makes sense, I'm hesitant - some transitions are natural (CONNECTED -> CONNECTED is okay), but some are... weird?
CREATED -> CREATED - can it even happen?
ERROR -> ERROR - I guess it's when connector consistently errors out?
CONFIGURED -> CONFIGURED - I guess it happens if you edit configuration and then quickly edit it again, before it's transitioned to CONNECTED?
| return VALID_TRANSITIONS.getOrDefault(current, Collections.emptySet()); | ||
| Set<ConnectorStatus> nextStates = new HashSet<>(VALID_TRANSITIONS.getOrDefault(current, Collections.emptySet())); | ||
| // Transition to the same state is allowed | ||
| nextStates.add(current); |
There was a problem hiding this comment.
Why not just add the explicit states in VALID_TRANSITIONS?
This obfuscates what are actually valid transitions by splitting the logic between that literal map and this function.
|
Thank you both for reviewing, yeah it makes sense to explicitly state this in the transition table. Let me update the PR :) |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
jedrazb
changed the title
|
@seanstory @artem-shelkovnikov I updated the PR. The changes are now to allow transition to same status for following statuses:
I'm changing this just for connectors. I don't think SyncJob logic needs any changes |
Changes
Update valid status transitions for
Connector. We should allow transition to same status for following statuses:CONNECTED(e.g. starting a sync if connector status is alreadyconnected)CONFIGURED(when sending multiple reqs to update configuration)ERROR(when multiple concurrent running jobs report error, e.g. content sync and access control job)Validations