Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for ScoringLuceneTopNSourceOperator #109663

Merged
merged 4 commits into from
Jun 19, 2024
Merged

Add test for ScoringLuceneTopNSourceOperator #109663

merged 4 commits into from
Jun 19, 2024

Conversation

tteofili
Copy link
Contributor

@tteofili tteofili commented Jun 13, 2024 •
edited
Loading

Just simple testing for ScoringLuceneTopNSourceOperator, plus minor javadoc change.

@tteofili tteofili changed the title Add test for LuceneTopNSourceOperator Add test for ScoringLuceneTopNSourceOperator Jun 13, 2024
ChrisHegarty
ChrisHegarty approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@ChrisHegarty ChrisHegarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tteofili tteofili marked this pull request as ready for review June 19, 2024 08:11
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jun 19, 2024
@tteofili tteofili merged commit fe25568 into elastic:esql/search Jun 19, 2024
9 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanatia ioanatia ioanatia approved these changes

@ChrisHegarty ChrisHegarty ChrisHegarty approved these changes

Assignees
No one assigned
Labels
needs:triage Requires assignment of a team area label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tteofili @ioanatia @ChrisHegarty @elasticsearchmachine