Track RequestedRangeNotSatisfiedException separately in S3 Metrics #109657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to RCO changes, we started getting a lot of `RequestedRangeNotSatisfiedException`s which are expected. We would like to not count them as failures and track them separately.
arteam
added
>enhancement
:Distributed/Snapshot/Restore
|
Hi @arteam, I've created a changelog YAML for you. |
|
Pinging @elastic/es-distributed (Team:Distributed) |
arteam
commented
Jun 13, 2024
...nalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryMetricsTests.java
Show resolved
Hide resolved
ywangd
reviewed
Jun 17, 2024
server/src/main/java/org/elasticsearch/repositories/RepositoriesMetrics.java
Show resolved
Hide resolved
kingherc
reviewed
Jun 17, 2024
server/src/main/java/org/elasticsearch/repositories/RepositoriesMetrics.java
Outdated
Show resolved
Hide resolved
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
…esMetrics.java Co-authored-by: Iraklis Psaroudakis <[email protected]>
…-not-satisfied-exceptions
kingherc
reviewed
Jun 18, 2024
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Show resolved
Hide resolved
kingherc
reviewed
Jun 19, 2024
...nalClusterTest/java/org/elasticsearch/repositories/s3/S3BlobStoreRepositoryMetricsTests.java
Outdated
Show resolved
Hide resolved
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Show resolved
Hide resolved
|
@elasticmachine update branch |
ywangd
approved these changes
Jun 20, 2024
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java
Outdated
Show resolved
Hide resolved
It's not useful since request range requests are not retryable and we should have mostly one error
|
@elasticmachine update branch |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to RCO changes, we started getting a lot of
RequestedRangeNotSatisfiedExceptions which are expected. We would like track them separately.This change a new metrics
es.repositories.exceptions.request_range_not_satisfied.totalto track all client errors analogous to other S3 errors.In the future, we can add the error code as an attribute to the metrics, so we can adapt it to all client errors.