Correct positioning for unique token filter #109395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 CLA has been signed |
|
Documentation preview: |
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @benwtrent, I've created a changelog YAML for you. |
|
@javanna I am unsure about a new deprecated setting to revert to the old behavior. It may be overkill. |
|
@shuaibiyy I know we are about 6 years later, but if you are still around, mind signing the CLA for this particular change? While the current evolution of the change has grown, I would still like you to get contribution credit if possible. |
|
Hi @benwtrent I've signed the CLA. Thanks! |
Increasing version and adding bwc version tests Fix documentation to account for next position
benwtrent
force-pushed
the
feature/unique-token-filter
branch
from
a8ae318
to
aaf2d04
Compare
|
@elasticmachine update branch |
|
@elasticmachine update branch |
|
@elasticmachine update branch |
cbuescher
approved these changes
Jun 20, 2024
...analysis-common/src/test/java/org/elasticsearch/analysis/common/XUniqueTokenFilterTests.java
Outdated
Show resolved
Hide resolved
.../analysis-common/src/test/java/org/elasticsearch/analysis/common/UniqueTokenFilterTests.java
Show resolved
Hide resolved
benwtrent
added
the
auto-merge
|
Hi @benwtrent, I've updated the changelog YAML for you. |
|
@elasticmachine update branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an extension of: #35420
closes: #35411