Lazily create the failure store #109289
Merged
Lazily create the failure store #109289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than initializing the failure store right away when a new data stream is created, we leave it empty and mark it for lazy rollover. This results in the failure store only being initialized (i.e. an index created) when a failure has actually occurred. The exception to the rule is when a failure occurs while the data stream is being auto-created. In that case we do want to initialize the failure store right away.
|
Pinging @elastic/es-data-management (Team:Data Management) |
gmarouli
reviewed
Jun 4, 2024
There was a problem hiding this comment.
Thanks for working on this @nielsbauman ! It looks good, I have started a couple of discussions and I am still running through potential scenarios. I haven't finished this yet, but I thought we do not have to delay the existing feedback while I do this :)
...reams/src/internalClusterTest/java/org/elasticsearch/datastreams/DataStreamsSnapshotsIT.java
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java
Outdated
Show resolved
Hide resolved
...ck/plugin/ccr/src/main/java/org/elasticsearch/xpack/ccr/action/TransportPutFollowAction.java
Show resolved
Hide resolved
...t/java/org/elasticsearch/action/bulk/TransportBulkActionIndicesThatCannotBeCreatedTests.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java
Show resolved
Hide resolved
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
gmarouli
reviewed
Jun 5, 2024
server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexRequest.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/admin/indices/create/CreateIndexRequest.java
Outdated
Show resolved
Hide resolved
jbaiera
reviewed
Jun 7, 2024
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/metadata/MetadataCreateDataStreamService.java
Outdated
Show resolved
Hide resolved
...streams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/170_modify_data_stream.yml
Show resolved
Hide resolved
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
This reverts commit 5f2e5c6.
gmarouli
reviewed
Jun 13, 2024
...ams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/200_rollover_failure_store.yml
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/TransportRolloverAction.java
Show resolved
Hide resolved
...r/src/main/java/org/elasticsearch/action/admin/indices/rollover/MetadataRolloverService.java
Show resolved
Hide resolved
jbaiera
reviewed
Jun 18, 2024
...ams/src/yamlRestTest/resources/rest-api-spec/test/data_stream/200_rollover_failure_store.yml
Show resolved
Hide resolved
# Conflicts: # server/src/main/java/org/elasticsearch/TransportVersions.java
gmarouli
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than initializing the failure store right away when a new data stream is created, we leave it empty and mark it for lazy rollover. This results in the failure store only being initialized (i.e. an index created) when a failure has actually occurred.
The exception to the rule is when a failure occurs while the data stream is being auto-created. In that case, we do want to initialize the failure store right away.