Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend ISO8601 parser to specify forbidden fields, allowing it to be used on more formats #108606

Merged
merged 12 commits into from
Jun 25, 2024

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented May 14, 2024

Adds parameters to specify the maximum allowed field, decimal separator, and timezone presence, so the ISO8601 parser can be used on more built-in formats.

@thecoop thecoop force-pushed the datetime-forbidden-fields branch from 8b28ccf to f0b3baf Compare May 14, 2024 10:23
@thecoop thecoop added >enhancement :Core/Infra/Core Core issues without another label labels May 14, 2024
@thecoop thecoop marked this pull request as ready for review May 14, 2024 11:36
@elasticsearchmachine elasticsearchmachine added the Team:Core/Infra Meta label for core/infra team label May 14, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Hi @thecoop, I've created a changelog YAML for you.

@thecoop thecoop changed the title Extends ISO8601 parser to specify forbidden fields, allowing it to be used on more formats Extend ISO8601 parser to specify forbidden fields, allowing it to be used on more formats May 14, 2024
@thecoop
Copy link
Member Author

thecoop commented May 14, 2024

@elasticmachine update branch

@thecoop thecoop requested a review from a team May 17, 2024 10:04
@thecoop thecoop added the WIP label May 17, 2024
@thecoop thecoop added WIP and removed WIP labels May 24, 2024
@thecoop thecoop removed the WIP label Jun 18, 2024
@thecoop
Copy link
Member Author

thecoop commented Jun 20, 2024

@elasticmachine update branch

Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a minor question and a nit

@thecoop thecoop merged commit 5fd41df into elastic:main Jun 25, 2024
14 checks passed
@thecoop thecoop deleted the datetime-forbidden-fields branch June 25, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >enhancement release highlight Team:Core/Infra Meta label for core/infra team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants