Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add task to update min CCS version #105550

Merged
merged 10 commits into from
Jun 24, 2024
Merged

Conversation

thecoop
Copy link
Member

@thecoop thecoop commented Feb 15, 2024

Add a task to update the min CCS transport version on release. Alternative to #105141

@thecoop thecoop marked this pull request as ready for review February 15, 2024 12:40
@thecoop thecoop requested a review from a team as a code owner February 15, 2024 12:40
@elasticsearchmachine elasticsearchmachine added Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team labels Feb 15, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-delivery (Team:Delivery)

@thecoop thecoop requested a review from rjernst February 15, 2024 14:06
@thecoop
Copy link
Member Author

thecoop commented Mar 12, 2024

@elasticmachine update branch

@thecoop
Copy link
Member Author

thecoop commented Mar 25, 2024

#106712 has added a method on TransportVersion (that can be copied to other version numbers if necessary) to make it easier to correctly declare patches on previously released transport versions, so the transport version could be updated if necessary between freeze & finalize.

@thecoop
Copy link
Member Author

thecoop commented Mar 25, 2024

@elasticmachine update branch

@thecoop
Copy link
Member Author

thecoop commented Jun 19, 2024

@elasticmachine update branch

@thecoop
Copy link
Member Author

thecoop commented Jun 21, 2024

@elasticmachine update branch

@thecoop thecoop requested a review from a team June 21, 2024 10:56
Copy link
Contributor

@ldematte ldematte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Quite interesting approach. IIRC this was the last version that needed manual bump, correct?

@thecoop
Copy link
Member Author

thecoop commented Jun 24, 2024

Yes, I still need to bump CCS for the 8.14 release

@thecoop thecoop merged commit 7106fa4 into elastic:main Jun 24, 2024
16 checks passed
@thecoop thecoop deleted the release-ccs-version branch June 24, 2024 10:27
@thecoop thecoop restored the release-ccs-version branch June 24, 2024 10:28
@thecoop thecoop deleted the release-ccs-version branch June 24, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Transport API Transport client API :Delivery/Build Build or test infrastructure >refactoring Team:Core/Infra Meta label for core/infra team Team:Delivery Meta label for Delivery team v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants