Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change equal methods #101293

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

change equal methods #101293

wants to merge 3 commits into from

Conversation

jww1226
Copy link

@jww1226 jww1226 commented Oct 25, 2023

Changing equal methods according to the issue #100870

@elasticsearchmachine elasticsearchmachine added v8.12.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Oct 25, 2023
@gbanasiak gbanasiak added the :Search/Search Search-related issues that do not fall into other categories label Oct 30, 2023
@elasticsearchmachine elasticsearchmachine added Team:Search Meta label for search team and removed needs:triage Requires assignment of a team area label labels Oct 30, 2023
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

cbuescher
cbuescher requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the three DecayFunction implementations need any equals or hashcode implementation, they are all three final static members so Object.equals should be sufficient. I would say lets remove them altogether.
OperationModeUpdateTask hasn't anything to do with the original issue, lets not touch it.

@Marcono1234
Copy link

Looks like this was superseded by #107415

(Thanks nonetheless for trying to fix the issue I had reported!)

@javanna javanna added :Search Relevance/Search Catch all for Search Relevance and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 17, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch label Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@elasticsearchmachine elasticsearchmachine removed the Team:Search Meta label for search team label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbuescher cbuescher cbuescher requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Relevance/Search Catch all for Search Relevance Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@jww1226 @elasticsearchmachine @Marcono1234 @cbuescher @brianseeders @javanna @gbanasiak