-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] ValuesIntAggregatorFunctionTests classMethod failing #109932
Comments
Pinging @elastic/es-analytical-engine (Team:Analytics) |
Amazing |
A bunch of tests ran mega slow and timed out. That's what we get I guess. It doesn't reproduce locally. I'll poke more tomorrow when I'm back. |
It's really slow. Like, can take a minute per test. Most of that time was in `containsInAnyOrder`. This replaces that with a check for a `Set` containing stuff. This came up because we hit a timeout on one of the values tests. I don't think these tests caused the timeout, but we may as well speed them up. Closes elastic#109932
Most tests are running fast but
This doesn't reproduce. At all. It takes 20 seconds locally. Here's the logging for some of the slow ones:
Here's the stacktrace around the timeout:
I've opened a PR (#110001) to speed up the tests. I don't think the timeout is actually the fault of the test, but it's something. |
It's really slow. Like, can take a minute per test. Most of that time was in `containsInAnyOrder`. This replaces that with a check for a `Set` containing stuff. This came up because we hit a timeout on one of the values tests. I don't think these tests caused the timeout, but we may as well speed them up. Closes elastic#109932
Build scan:
https://gradle-enterprise.elastic.co/s/be7jmqtelosou/tests/:x-pack:plugin:esql:compute:test/org.elasticsearch.compute.aggregation.ValuesIntAggregatorFunctionTests
Reproduction line:
Applicable branches:
main
Reproduces locally?:
Didn't try
Failure history:
Failure dashboard for
org.elasticsearch.compute.aggregation.ValuesIntAggregatorFunctionTests#classMethod
Failure excerpt:
The text was updated successfully, but these errors were encountered: