-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] IndexShardTests testScheduledRefresh failing #101008
Comments
Pinging @elastic/es-distributed (Team:Distributed) |
I haven't been able to work this one out, nor can I see any other similar failures, and it hasn't reproduced after 30k iterations even on a CPU-stressed test machine. I opened #102079 to add some logging that might throw a little more light on the problem should it fail again. I'm pretty sure we can downgrade this to |
After tens of thousands more iterations overnight I've still not seen any failures of this test. I've added more logging but I'm going to close this. If/when it fails again we can reopen and try and investigate further. |
I believe it started failing again. Reproduction line:
Failure history: |
Failing in 8.13 too, muting there as well: https://gradle-enterprise.elastic.co/s/w2hu3tmgrzr7g |
After we flushed the shard, we only make sure that the refresh call is propagated to the shard engine, but we can't be sure that the call is actually ends up in a shard refresh. The call in `InternalEngine#refresh` can return `false` if we couldn't acquire the lock on `ElasticsearchDirectoryReader`, because it's already being refreshed. We can wrap the call in `assertBusy` to retry it in order to make sure that the shard eventually gets refreshed. Resolves #101008
Build scan:
https://gradle-enterprise.elastic.co/s/bwrmwilszqh5q/tests/:server:test/org.elasticsearch.index.shard.IndexShardTests/testScheduledRefresh
Reproduction line:
Applicable branches:
main
Reproduces locally?:
No
Failure history:
https://gradle-enterprise.elastic.co/scans/tests?tests.container=org.elasticsearch.index.shard.IndexShardTests&tests.test=testScheduledRefresh
Failure excerpt:
The text was updated successfully, but these errors were encountered: