Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More use cases cleanup #57

Merged
merged 2 commits into from
Jul 30, 2018
Merged

More use cases cleanup #57

merged 2 commits into from
Jul 30, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Jul 27, 2018

  • Add better description on how use cases are used
  • Complete use cases table with ECS type, example, description if none is provided
  • Adjust apm use case to use @timestamp
  • Clean up generation script to not link prefix.* entries
  • Refactor fields cleanup part

@ruflin ruflin added the review label Jul 27, 2018
@ruflin ruflin requested a review from andrewkroh July 27, 2018 09:53
ruflin
ruflin commented Jul 27, 2018
View reviewed changes
docs/use-cases-header.md Outdated
ECS fields can be applied to common use cases.
These are example on how ECS fields can be used in different use cases. Most use
cases not only contain ECS fields but additional fields which are not in ECS to
describe the full use case. The fields which are not in ECS are italic.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrewkroh are italic sounds strange but not sure how to put it in english.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest "are in italic".

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, updated.

@ruflin
More use cases cleanup
bbaba80 
* Add better description on how use cases are used
* Complete use cases table with ECS type, example, description if none is provided
* Adjust apm use case to use `@timestamp`
* Clean up generation script to not link `prefix.*` entries
* Refactor fields cleanup part
andrewkroh
andrewkroh approved these changes Jul 27, 2018
View reviewed changes
docs/use-cases-header.md Outdated
ECS fields can be applied to common use cases.
These are example on how ECS fields can be used in different use cases. Most use
cases not only contain ECS fields but additional fields which are not in ECS to
describe the full use case. The fields which are not in ECS are italic.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest "are in italic".

@andrewkroh andrewkroh merged commit 16a4312 into elastic:master Jul 30, 2018
@ruflin ruflin mentioned this pull request Aug 2, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruflin @andrewkroh