Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the difference between @timestamp and event.created #329

Merged
merged 7 commits into from
Feb 22, 2019

Conversation

webmat
Copy link
Contributor

@webmat webmat commented Feb 18, 2019

Closes #326

schemas/base.yml Outdated
@@ -14,8 +14,11 @@
description: >
Date/time when the event originated.

For log events this is the date/time when the event was generated, and
not when it was read.
This is the date/time extracted from the event, representing when the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should probably say "This is the date/time extracted from the event, typically representing when the"

schemas/base.yml Outdated
This is the date/time extracted from the event, representing when the
event was generated by the source.

If the event source has no original timestamp, this value must be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"this value must be" seems too restrictive. We've previously defined must and should semantics to indicate whether ECS will break or will cause unexpected results. I suggest changing this to "this value is typically"

The same could apply to package capturing where @timestamp contains the
timestamp extracted from the network package and event.created when the
event was created.
event.created contains the time when the event was first read by an
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"event.created contains the time when the event was first read by an" should be
"event.created typically contains the date/time when the event was first read by an"

event.created contains the time when the event was first read by an
agent, or by your pipeline.

This field is distinct from @timestamp in that @timestamp should contain
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"This field is distinct from @timestamp in that @timestamp should contain" should be
"This field is distinct from @timestamp in that @timestamp typically contains"

the time extracted from the original event.

In most situations, these two timestamps will be slightly different.
The difference will represent the delay between your source
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The difference will represent the delay between your source" could be
"The difference can be used to calculate the delay between your source"


In most situations, these two timestamps will be slightly different.
The difference will represent the delay between your source
generating it, when your agent first processed it. This can be used to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"generating it, when your agent first processed it. This can be used to" should be
"generating an event, and the time when your agent first processed it. This can be used to"

In most situations, these two timestamps will be slightly different.
The difference will represent the delay between your source
generating it, when your agent first processed it. This can be used to
monitor your agent's ability to keep up with your event source.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"monitor your agent's ability to keep up with your event source." should be
"monitor your agent's or pipeline's ability to keep up with your event source."

Latter to try to avoid further conflicts with other PRs
@webmat webmat merged commit 5bf9888 into elastic:master Feb 22, 2019
@webmat webmat deleted the clarify-event-created branch February 22, 2019 21:08
webmat added a commit to webmat/ecs that referenced this pull request Mar 5, 2019
webmat added a commit that referenced this pull request Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants