Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix url.original example #255

Merged
merged 1 commit into from
Dec 7, 2018
Merged

Fix url.original example #255

merged 1 commit into from
Dec 7, 2018

Conversation

ruflin
Copy link
Member

@ruflin ruflin commented Dec 7, 2018

Currently examples do not allow multiple lines. This is a quick fix, we must find something nicer in the future.

@ruflin
Fix url.original example
450d4ac 
Currently examples do not allow multiple lines. This is a quick fix, we must find something nicer in the future.
@ruflin ruflin added the review label Dec 7, 2018
@ruflin ruflin requested a review from webmat December 7, 2018 15:45
webmat
webmat approved these changes Dec 7, 2018
View reviewed changes
Copy link
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I'm not a fan of having both examples in the same section, but this is a minor cosmetic issue for later.

@ruflin
Copy link
Member Author

ruflin commented Dec 7, 2018

me neither but couldn't find a better solution quickly.

@webmat webmat merged commit 7f62686 into elastic:master Dec 7, 2018
@webmat webmat deleted the fix-url.original-example branch December 7, 2018 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmat webmat webmat approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ruflin @webmat