Add minimal field set to represent groups. #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45d2936
to
71d1801
Compare
ruflin
approved these changes
Dec 3, 2018
ruflin
reviewed
Dec 3, 2018
ruflin
approved these changes
Dec 3, 2018
MikePaquette
pushed a commit
to MikePaquette/ecs-1
that referenced
this pull request
Dec 4, 2018
Also fix a field name mistake in the changelog for elastic#204
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want more fields under
group.eventually, but I figured we could start with the two most obvious fields.Note that we're already starting to use them in the Beats transition to ECS. E.g. elastic/beats#9138