CTI 1.11 Addendum #1502
Merged
CTI 1.11 Addendum #1502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Subfields (as.*, geo.*) pertaining to indicators are removed from `threat.enrichments`; they will live under `threat.indicator` instead * `threat.enrichments` is now just a nested list of `indicator` and `matched` subfields While requiring a few more mappings, this greatly simplifies the logic and complexity of enrichment itself.
The notable absence here is the `event.*` fieldset, whose purpose will momentarily be replaced by `indicator.reference` and `indicator.provider`.
Since we no longer copy event.* during enrichment, these fields need to live under threat.indicator if we want them in an enrichment (which we do).
threat.indicator.dataset and threat.indicator.module are not specified in this RFC. This data should already exist on the indicator document as event.dataset and event.module. As they are not needed for the purposes of enrichment, they do not need to be present under threat.indicator.
The current ECS tooling does not allow us to do the following:
- name: threat.indicator
reusable:
expected:
- at: threat.enrichments
as: indicator
to convey the fact that threat.enrichments.indicator is the
threat.indicator fields nested under threat.enrichments.indicator.
Instead, we need to:
1. define the reused fields twice, under threat.indicator AND
threat.enrichments.indicator (this commit)
2. Copy the new threat.indicator.* fields as new
threat.enrichments.indicator.* fields (next commit)
The current ECS tooling does not allow us to do the following:
- name: threat.indicator
reusable:
expected:
- at: threat.enrichments
as: indicator
to convey the fact that threat.enrichments.indicator is the
threat.indicator fields nested under threat.enrichments.indicator.
Instead, we need to:
1. define the reused fields twice, under threat.indicator AND
threat.enrichments.indicator (last commit)
2. Copy the new threat.indicator.* fields as new
threat.enrichments.indicator.* fields (this commit)
devonakerr
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ebeahan I think this is ready for review, just a few questions:
indicatorfields are not present underthreat.enrichments! How do I go about definingthreat.enrichments.indicator.*as coming fromthreat.indicator.*?