Add level (Core, Extended) on all fields. #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@webmat We could even split this up further. In a first PR only to the fields.yml modification and follow up with scripts etc. in parallel. Let me know in case this is ready for review. It seems to have all the fields.yml changes inside? |
|
@ruflin Yes that's true. I'll modify the scripts in a separate PR. All fields should be assigned. If one is not, or if it's not == to the voting doc, it's a bug :-) |
ruflin
approved these changes
Oct 4, 2018
|
LGTM. Thanks @webmat ! |
|
Thanks folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subtasks:
phaseThis issue is only meant to cover assigning a level to the fields for #93. No modifications to the scripts in this PR.