Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add CreateTags for Easy Setup of CNI Addon #7702

Closed
wants to merge 1 commit into from

Conversation

hofq
Copy link

@hofq hofq commented Apr 5, 2024

Description

For easy setup of the CNI Addon as in the Example, the CreateTags Permission is missing.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 馃く

  • Backfilled missing tests for code in same general area 馃帀
  • Refactored something and made the world a better place 馃専

Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hofq, VPC CNI needs the ec2:CreateTags permission only on network interfaces, but the proposed change will allow it access to all resource types due to the * wildcard.

This list is also obsolete as it's missing permissions to other actions like ec2:DescribeSubnets which is required for the relatively new prefix mode feature. I would recommend removing attachPolicy from this example and instead link to this official page.

Also, unless you're scoping down permissions for your specific use case, it's recommended to use the leave attachPolicy and attachPolicyARNs unset for vpc-cni as eksctl will default to the recommended AmazonEKS_CNI_Policy managed policy.

@github-actions github-actions bot added the stale label May 9, 2024
@github-actions github-actions bot closed this May 15, 2024
@cPu1 cPu1 removed the stale label May 15, 2024
@cPu1 cPu1 reopened this May 15, 2024
@hofq hofq closed this Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants