Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive HTML theme #28

Open
GoogleCodeExporter opened this issue Aug 23, 2015 · 3 comments
Open

Responsive HTML theme #28

GoogleCodeExporter opened this issue Aug 23, 2015 · 3 comments
Assignees
@adam-waldenberg
Labels
Auto Migrated Enhancement Priority : Medium Usability
Milestone
0.5.0

Comments

@GoogleCodeExporter
Copy link 

Hello gitinspector folks. I'm using gitinspector to chew through a handful of 
repositories and output the reports to `html`. I am a front-end developer and 
interested in developing a more responsive, modern UI for my reports - but 
instead of just hacking my local copy I was wondering what the Correct Way™ 
to go about this was to be ab able to commit my changes bak upstream, or as an 
alternative output format if other want to use it.

Is there a git repository of the source somewhere I could fork and commit my 
changes, or what's my best bet for adding to what you already have without my 
codebase going stale?

Thanks for the help!

Original issue reported on code.google.com by [email protected] on 15 Apr 2014 at 9:52
@GoogleCodeExporter
Copy link
Author 

Hi. I was actually planning an adaption towards Bootstrap 3. However, this is 
far down on the todo list. In any case, I might be willing to completely 
replace the current output with your solution if it's an improvement :).

It's better to just have one HTML output and do it really well.

You have two options:
1. Hack away and attach a diff patch with the commits to this issue.
2. Clone the repository at http:https://code.google.com/p/gitinspector/source/clones. 
I can then cherry pick / merge your commits.

What you will need to modify:
html/html.header (contains all css and javascript)
html/html.footer

Also, each module that outputs html extends the Outputable class and implements 
the html output inside output_html().

Try to strive for small commits and follow our conventions for commit messages 
and source code layout. Running pylint often helps (use the configuration file 
provided in the root directory).

Don't hesitate to ask if you have any questions. :)

/Adam Waldenberg

Original comment by [email protected] on 16 Apr 2014 at 2:51

  • Changed state: Accepted
  • Added labels: Usability

@GoogleCodeExporter
Copy link
Author

Original comment by [email protected] on 24 Nov 2014 at 8:04

  • Added labels: Milestone-Release0.6.0

@adam-waldenberg adam-waldenberg added this to the 0.5.0 milestone Aug 24, 2015
adam-waldenberg added a commit that referenced this issue Nov 3, 2015
@adam-waldenberg
Upgraded the JQuery version in the flot archive to 1.9.1 (#28).
87fd5b4 
This is the minimal version required by Bootstrap3 (which we will
base the new responsive HTML theme on). This upgrade required changes
to the JavaScript code, as toggle(...) has been deprecated since
version 1.9.x of JQuery.
@adam-waldenberg
Copy link
Member

Slowly begining work on this.

@adam-waldenberg adam-waldenberg self-assigned this Nov 3, 2015
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Added BootStrap3 to the archive and improved format.py (#28).
7a6b7c7 
We now use more external resources in the normal HTML output (cdnjs).
This makes the generated HTML substantially smaller.

Also took the opportunity to add a comment about the slightly
modified tablesorter.js plug in that we are using.
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Added BootStrap3 to the archive and improved format.py (#28).
75f1924 
We now use more external resources in the normal HTML output (cdnjs).
This makes the generated HTML substantially smaller.

Also took the opportunity to add a comment about the slightly
modified tablesorter.js plug in that we are using.
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Slightly reworked styling and added use of "table-striped" class (#28).
4396e99 
Most of the old CSS rules are currently commented out but left
intact to serve as a reference during development.

While this change completely breaks the HTML output, I'm considering
this iteration a first test.
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Increased the size of gravatars in the HTML output (#28).
5ed8b32
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Removed old HTML output header "hack" calculation (#28).
d11bcdd 
This is unnecessary and breaks any new responsive designs.
adam-waldenberg added a commit that referenced this issue Nov 7, 2015
@adam-waldenberg
Changed "graphical glyphs" to solid arrows (#28).
dcbc663 
The $or; character was changed to $#x25bc;, while $and; was changed to
$#x25b2.
adam-waldenberg added a commit that referenced this issue Nov 10, 2015
@adam-waldenberg
The HTML blame output now behaves similarly to the changes output (#28).
c90ac5a
adam-waldenberg added a commit that referenced this issue Nov 13, 2015
@adam-waldenberg
Replaced table footers with buttons and fixed zebra coloring (#28).
937ac44 
Apart from the aforementioned changes, some slight improvements were
also done to the styling of the table.

The buttons utilize a check mark symbol instead of modifying the
button text upon selection.
adam-waldenberg added a commit that referenced this issue Nov 14, 2015
@adam-waldenberg
Disable buttons when no minor authors exist (#28).
cb72710
adam-waldenberg added a commit that referenced this issue Nov 23, 2015
@adam-waldenberg
Removed dangling table footer in changes HTML output (#28).
aa7c720
adam-waldenberg added a commit that referenced this issue Nov 23, 2015
@adam-waldenberg
Fixed excess margin in outputted HTML tables (#28).
a39ee4d
adam-waldenberg added a commit that referenced this issue Nov 24, 2015
@adam-waldenberg
Hovering over table headers now shows a cursor pointer (#28).
0c4e4bf
adam-waldenberg added a commit that referenced this issue Nov 24, 2015
@adam-waldenberg
Use MINOR_AUTHOR_PERCENTAGE in output modules (#28).
7945dbb 
Consequently, we now only need to change the percentage in one place if
we want to modify the lower bound for minor authors.
adam-waldenberg added a commit that referenced this issue Nov 25, 2015
@adam-waldenberg
HTML pie charts in the changes and blame outputs now work again (#28).
9bbd5fc 
While not yet perfect, the implementation is fully responsive and reacts
to window re-sizing. However, the design needs much more work before we
can consider it completed.
adam-waldenberg added a commit that referenced this issue Dec 25, 2015
@adam-waldenberg
Removed some dead code from the HTML JavaScript output (#28).
db03f37
adam-waldenberg added a commit that referenced this issue Dec 25, 2015
@adam-waldenberg
Slightly moved HTML changes & blame minor authors buttons (#28).
0f52711 
These are now placed above the horizontal ruler of each section instead
of the previous positioning.
adam-waldenberg added a commit that referenced this issue Dec 26, 2015
@adam-waldenberg
Slightly optimized the CSS rules of the HTML output (#28).
5a8e84c
adam-waldenberg added a commit that referenced this issue Dec 26, 2015
@adam-waldenberg
Re-implement timeline in the HTML outpout (#28).
7f74b6a 
While the timeline itself is displayed just fine, filtering of minor
authors has not been re-added yet.
@adam-waldenberg adam-waldenberg mentioned this issue May 11, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adam-waldenberg adam-waldenberg

Labels
Auto Migrated Enhancement Priority : Medium Usability
Projects
None yet
Milestone
0.5.0
Development

No branches or pull requests
2 participants
@adam-waldenberg @GoogleCodeExporter