Skip to content
This repository has been archived by the owner on Apr 5, 2024. It is now read-only.

hotsapi.net upload support #162

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

hotsapi.net upload support #162

wants to merge 3 commits into from

Conversation

sloonz
Copy link

@sloonz sloonz commented Sep 13, 2017

Upload to hotsapi.net in addition to hotslogs.

Since hotslogs & hotsapi both use the same format for match ID, I could reuse most of the code of HotsLogsProvider and moved the common code to a new class ReplayUtils.

@sloonz
Copy link
Author

sloonz commented Sep 14, 2017

Note that right now duplicate detection does not works ; see hotsapi/hotsapi#38

@sloonz
Copy link
Author

sloonz commented Sep 14, 2017

Duplicate detection is now working

@eivindveg
Copy link
Owner

We currently aren't supporting multiple provider(the API does, but the application design doesn't). In the future, we do intend to solve this, but this pull request cannot be included before that.

@poma
Copy link

poma commented Sep 16, 2017

but the application design doesn't

Do you mean GUI or architecture?

@eivindveg
Copy link
Owner

Both. I do wish to get support for multiple providers in, but I do want to do it in a way every provider can be toggled. One thing I have been working on is a configuration panel, which would allow us to do that.

GUI design-wise, we'd also need to fiddle with the list, such as displaying icons for targets a replay has been uploaded to before it's fully uploaded and removed from the list. This shouldn't be too complex, but the former issue needs to be resolved first.

@ixidion
Copy link

ixidion commented Sep 23, 2017

@eivindveg thinking about helping with the integration and other necessary related tasks. Whats your vision for the UI/Settings panel?

@eivindveg
Copy link
Owner

I appreciate any help with the design/layout of the settings panel. I'd like to design the internal settings engine myself before it's reviewed.

@eivindveg eivindveg self-assigned this Sep 23, 2017
@eivindveg eivindveg added this to the 2.2 milestone Sep 23, 2017
@eivindveg eivindveg added this to TODO in Multiple Providers Sep 23, 2017
@eivindveg
Copy link
Owner

We will be integrating this pull request in 2.2 along with multi-provider support. Keep in mind that this will result in conflicts for this pull request which will have to be resolved. To make this easier, please prepare the following information:

  • Name of your provider, for example HotsLogs
  • ID of your provider, for example hots-logs
  • A small(16x16 or 32x32) logo for your provider, such as a favicon

@poma
Copy link

poma commented Sep 23, 2017

For hotsapi:

@MGatner
Copy link

MGatner commented Jun 8, 2018

@eivindveg curious if you've moved ahead with multi-provider support? Working on macOS support for Hotsapi.Uploader (hotsapi/Hotsapi.Uploader#5) and this was linked as a possible solution.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants