Attempting to fix #724: Use provided target host credentials also when downloading via proxy. #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, let's go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR tries to fix issue #724 by adding both the proxy credentials (if present) and the target host credentials (if present) to the
CredentialsProviderpassed to the http client when downloading node, yarn or npm.Tests and Documentation
Unfortunately, it seems there were no integration tests for neither the proxy nor the authentication feature so far. I could maybe try to provide one or two tests. It would, however, involve some new dependencies, since we'd need to start a simple proxy and/or http mock server of some sort prior to integration tests. Should you have any ideas/recommendations please let me know.