add support for armv7l (ignores armv6l) #705
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for armv7l (ignores armv6l) for "arm" architecture (as detected by Java system property "os.arch").
Related to issue #704
This PR adds support for installing node on armv7l on a Raspberry Pi.
On the LTS node download site: https://nodejs.org/dist/v8.10.0/
there are only two choices for "arm" versions of node ("aarch64" is a different case): armv6l and armv7l. This patch simply uses the newer v7 flavor.
Tests and Documentation
I ran the following test code on a raspberry pi to confirm the behavior produced valid node download URLs:
The test output was:
That output should produce a valid download URL from this page:
https://nodejs.org/dist/v8.10.0/