Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-node-and-pnpm does not detect previously installed pnpm #1039

Closed
nils-christian opened this issue Jul 5, 2022 · 1 comment
Closed

Comments

@nils-christian
Copy link
Contributor

nils-christian commented Jul 5, 2022

Do you want to request a feature or report a bug?

This is a bug similar to #519.

What is the current behavior?

When running install-node-and-pnpm multiple times, it does not detect that pnpm was installed when run previously and instead installs pnpm from scratch each time. See log messages:

[INFO] --- frontend-maven-plugin:1.12.0:install-node-and-pnpm (default-cli) @ test ---
[INFO] Node v14.15.5 is already installed.
[INFO] PNPM 5.18.10 was installed, but we need version v5.18.10
[INFO] Installing pnpm version v5.18.10

What is the expected behavior?

pnpm should only be installed when it is either not installed or the version is actually different.

Please mention your frontend-maven-plugin and operating system version.

The frontend-maven-plugin-Version is 1.12.1, the OS is a windows based system.

nils-christian added a commit to nils-christian/frontend-maven-plugin that referenced this issue Jul 6, 2022
@nils-christian
Copy link
Contributor Author

I created a PR to solve this issue: #1040

eirslett added a commit that referenced this issue Jul 10, 2022
[#1039] install-node-and-pnpm does not detect previously installed pnpm
@eirslett eirslett closed this as completed Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants