Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache events listeners descend too far down the "firing sequence" for "unfireable events" #3169

Open
chrisdennis opened this issue Jun 6, 2023 · 2 comments
Open

Cache events listeners descend too far down the "firing sequence" for "unfireable events" #3169

chrisdennis opened this issue Jun 6, 2023 · 2 comments
Assignees
@chrisdennis
Labels
enhancement in progress

Comments

@chrisdennis
Copy link
Member

Cache events listeners will get all the way to dispatching a task, including potentially spawning a thread , for events of a type for which there are no listeners. We have all the knowledge available to trim the call tree much sooner, and should be doing so.
@chrisdennis chrisdennis self-assigned this Jun 6, 2023
chrisdennis added a commit to chrisdennis/ehcache3 that referenced this issue Jun 6, 2023
@chrisdennis
Fixes ehcache#3169 : Track event listeners keyed by type to allow ear…
2420642 
…lier event firing veto
chrisdennis added a commit to chrisdennis/ehcache3 that referenced this issue Jun 6, 2023
@chrisdennis
Fixes ehcache#3169 : Track event listeners keyed by type to allow ear…
162a5ea 
…lier event firing veto
@SamuelBussmann
Copy link

SamuelBussmann commented Sep 12, 2023 •
edited

Is there anything I can do to support resolving this issue?

SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Sep 26, 2023
@SamuelBussmann
Reapply: PR ehcache#3170
44d50b8 
Fixes ehcache#3169 : Track event listeners keyed by type to allow earlier event
firing veto ehcache#3170
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Sep 26, 2023
@SamuelBussmann
Fixes ehcache#3169: Register only those CacheEvents with correspondin…
6db8080 
…g listener
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Sep 26, 2023
@SamuelBussmann
Fixes ehcache#3169: Inline unordered/asynch listener execution to avo…
3c3ca34 
…id submit

delay
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 17, 2024
@SamuelBussmann
Fixes ehcache#3169: clean-ups & test fixes
a80a9f4
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 18, 2024
@SamuelBussmann
Reapply: PR ehcache#3170
155fb3d 
Fixes ehcache#3169 : Track event listeners keyed by type to allow earlier event
firing veto ehcache#3170
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 18, 2024
@SamuelBussmann
Fixes ehcache#3169: Register only those CacheEvents with correspondin…
14ec4e1 
…g listener
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 18, 2024
@SamuelBussmann
Fixes ehcache#3169: Inline unordered/asynch listener execution to avo…
5e4c4f3 
…id submit

delay
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 18, 2024
@SamuelBussmann
Fixes ehcache#3169: clean-ups & test fixes
3699f01
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 18, 2024
@SamuelBussmann
Fixes ehcache#3169: fix compile error after rebase
f709f55
@SamuelBussmann
Copy link

I've created an alternative/extended solution to this issue through Pull-Request #3236
I hope you can have a look at it and check whether it is a viable solution worth checking further.

SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 25, 2024
@SamuelBussmann
Fixes ehcache#3169: signal listenerModified on listener removal
7f52e7b
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 25, 2024
@SamuelBussmann
Fixes ehcache#3169: add additional Tests for new EventType filtering
c2ac118
SamuelBussmann added a commit to SamuelBussmann/ehcache3 that referenced this issue Jul 25, 2024
@SamuelBussmann
Fixes ehcache#3169: clean-up formatting
88a167d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisdennis chrisdennis

Labels
enhancement in progress
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chrisdennis @SamuelBussmann