Skip to content

Commit

Permalink
Fix flaky subtest f2fsslower in test_tools_smoke.py (iovisor#3531)
Browse files Browse the repository at this point in the history
The f2fsslower.py may return earlier if the kernel does not
have required functions. For example, on my system,

  $ sudo python3.6 ./f2fsslower.py
  ERROR: no f2fs_file_operations in /proc/kallsyms. Exiting.
  HINT: the kernel should be built with CONFIG_KALLSYMS_ALL.
  $ echo $?
  0

So set allow_early to be True when testing f2fsslower.py
in test_tools_smoke.py.

Signed-off-by: Yonghong Song <[email protected]>
  • Loading branch information
yonghong-song committed Jan 30, 2024
1 parent 9e8572c commit a53e361
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/python/test_tools_smoke.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ def test_ext4slower(self):

@skipUnless(kernel_version_ge(4,4), "requires kernel >= 4.4")
def test_f2fsslower(self):
self.run_with_int("f2fsslower.py")
self.run_with_int("f2fsslower.py", allow_early=True)

@skipUnless(kernel_version_ge(4,4), "requires kernel >= 4.4")
def test_filelife(self):
Expand Down

0 comments on commit a53e361

Please sign in to comment.