Skip to content

Commit

Permalink
[bcc test] Simplify workflow
Browse files Browse the repository at this point in the history
During the bcc-test workflow, we do not really need `installed_llvm_versions`
as we only need to build the ephemeral container for the llvm version we are testing
(e.g matrix.llvm_version).
This container is only built IFF a docker file is changed in order to make
sure the PR runs on a container which has the changes from the docker file.
At the end of the day, the container that we use only needs 1 llvm version installed,
the one we test.
  • Loading branch information
chantra committed Oct 21, 2023
1 parent 2ad5263 commit 5e0a7d8
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/bcc-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
os: [{distro: "ubuntu", version: "18.04", nick: bionic, installed_llvm_versions: "11 12"}, {distro: "ubuntu", version: "20.04", nick: focal, installed_llvm_versions: "11 12 15"}]
os: [{distro: "ubuntu", version: "18.04", nick: bionic}, {distro: "ubuntu", version: "20.04", nick: focal}]
llvm_version: [11, 12, 15]
env:
- TYPE: Debug
Expand All @@ -34,7 +34,7 @@ jobs:
PYTHON_TEST_LOGFILE: critical.log
RW_ENGINE_ENABLED: ON
exclude:
- os: {distro: "ubuntu", version: "18.04", nick: bionic, installed_llvm_versions: "11 12"}
- os: {distro: "ubuntu", version: "18.04", nick: bionic}
llvm_version: 15
steps:
- uses: actions/checkout@v2
Expand All @@ -59,7 +59,7 @@ jobs:
os_distro: ${{ matrix.os.distro }}
os_version: ${{ matrix.os.version }}
os_nick: ${{ matrix.os.nick }}
llvm_versions: ${{ matrix.os.installed_llvm_versions }}
llvm_versions: ${{ matrix.llvm_version }}
- name: Tag docker container
run: |
docker tag ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }}:${{ matrix.os.distro }}-${{ matrix.os.version }} bcc-docker
Expand Down

0 comments on commit 5e0a7d8

Please sign in to comment.