-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chart builders with data parameter for all charttypes #1132
Comments
I believe that's because PieChart only has a single dimension, whereas the other charts support multiple dimensions so it's more convenient to generate series of data using the |
That makes sense. However, in my application the val series = observableListOf<XYChart.Serie>();
linechart {
data.bind(series);
} Would it make sense to add a convenience constructor parameter for this use-case? |
Sure :) It's in line with how the other builders work, so a PR would be welcome :) |
@HoldYourWaffle I’ll get this merged in. Can you also submit one for the jdk10 branch to make it easy? ;) |
Is there a reason why only the
piechart
builder has adata
parameter?tornadofx/src/main/java/tornadofx/Charts.kt
Lines 7 to 14 in e63f086
tornadofx/src/main/java/tornadofx/Charts.kt
Lines 33 to 37 in e63f086
The text was updated successfully, but these errors were encountered: