Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add OpenZiti to edgex-go #4777

Merged
merged 15 commits into from
Mar 20, 2024

Conversation

dovholuknf
Copy link
Contributor

original pr here - closed mistakenly when trying to sync my main branch using github: #4755

This PR enables the core microservices to be built with support for OpenZiti. Without the individual changes to the files, after building docker images locally (make docker_base -> make docker) without the individual changes the ListenMode was never correctly discovered as 'zerotrust'

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-common-config-bootstrapper/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-command/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/core-metadata/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/support-notifications/res/configuration.yaml Outdated Show resolved Hide resolved
cmd/support-scheduler/res/configuration.yaml Outdated Show resolved Hide resolved
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update the go.mod file to use the latest go-mod-bootstrap.

@codecov-commenter
Copy link

codecov-commenter commented Mar 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.62%. Comparing base (6cbb312) to head (f3679e6).

❗ Current head f3679e6 differs from pull request most recent head 1abee86. Consider uploading reports for the commit 1abee86 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4777   +/-   ##
=======================================
  Coverage   41.62%   41.62%           
=======================================
  Files         105      105           
  Lines        9858     9858           
=======================================
  Hits         4103     4103           
  Misses       5402     5402           
  Partials      353      353           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lenny-goodell lenny-goodell merged commit d2d9888 into edgexfoundry:main Mar 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants